Adding a configurable TTL cache for get_ethBalance to eth.ts #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
1059-eth-get-balance-cache
branch
from
1bbe0c9 to
ec1302a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 74.40% 74.68% +0.28%
==========================================
Files 31 31
Lines 2051 2074 +23
Branches 391 395 +4
==========================================
+ Hits 1526 1549 +23
Misses 417 417
Partials 108 108
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
AlfredoG87
requested review from
a team,
ebadiere and
lukelee-sl
as code owners
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Apr 14, 2023
AlfredoG87
added a commit
that referenced
this pull request
Apr 14, 2023
* Adding a configurable TTL cache for get_ethBalance to eth.ts Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache for blockNumber aswell Signed-off-by: Alfredo Gutierrez <[email protected]> --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added a commit
that referenced
this pull request
Apr 15, 2023
* Adding a configurable TTL cache for get_ethBalance to eth.ts Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache for blockNumber aswell Signed-off-by: Alfredo Gutierrez <[email protected]> --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
Nana-EC
pushed a commit
that referenced
this pull request
Apr 15, 2023
* Adding a configurable TTL cache for get_ethBalance to eth.ts Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache for blockNumber aswell Signed-off-by: Alfredo Gutierrez <[email protected]> --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
2 tasks
Nana-EC
pushed a commit
that referenced
this pull request
Apr 15, 2023
* Adding a configurable TTL cache for get_ethBalance to eth.ts Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache Signed-off-by: Alfredo Gutierrez <[email protected]> * Added logs for cache for blockNumber aswell Signed-off-by: Alfredo Gutierrez <[email protected]> --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
lukelee-sl
pushed a commit
that referenced
this pull request
Apr 15, 2023
…1076) * Adding a configurable TTL cache for get_ethBalance to eth.ts * Added logs for cache * Added logs for cache for blockNumber aswell --------- Signed-off-by: Alfredo Gutierrez <[email protected]> Co-authored-by: Alfredo Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a configurable TTL cache for get_ethBalance to eth.ts
Related issue(s):
Fixes #1059
Notes for reviewer:
Checklist